This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Update env.py #285
Closed
Update env.py #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's my PR where I previously made style changes to env.py: As you can see, my suggestion to fully match the style of isort wasn't taken up on, so I would say that yes, they specifically choose not to fix it. That's why I ended up doing an exclude, since I really quickly ran into style issues when I updated the migrations. So am a fan of #2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #284
With this being generated by the environment file I would like to propose another potential fix to ignore the issue either with:
1 - manually with a
# ruff: noqaappended to the top of the file.or
2 - We can also modify the `extend-exclude to include ALL files in the migrations (and not just the version info)
1 doesn't solve the issue long term either as if we ever need to regenerate the file the problem would appear again (which is the concern currently)
2 is a little better but this fix is harmless.
I do wonder if this is something that could be fixed on the alembic end (unless they specifically chose not to fix it)